netdev - Re: [PATCH net-next]r8169: Correct values on dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150727205526.GA8398@electric-eye.fr.zoreil.com>
Date:	Mon, 27 Jul 2015 22:55:26 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Corcodel Marian <corcodel.marian@...il.com>
Cc:	netdev@...r.kernel.org, Corcodel Marian <asu@...-168-0-3.rdsnet.ro>
Subject: Re: [PATCH net-next]r8169: Correct values on dma_alloc_coherent

Corcodel Marian <corcodel.marian@...il.com> :
[...]
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 3df51fa..fd249a6 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -6724,8 +6724,8 @@ static int rtl8169_init_ring(struct net_device *dev)
>  
>  	rtl8169_init_ring_indexes(tp);
>  
> -	memset(tp->tx_skb, 0x0, NUM_TX_DESC * sizeof(struct ring_info));
> -	memset(tp->Rx_databuff, 0x0, NUM_RX_DESC * sizeof(void *));
> +	memset(tp->tx_skb, 0x0, NUM_RX_DESC);
> +	memset(tp->Rx_databuff, 0x0, NUM_RX_DESC);

	void *Rx_databuff[NUM_RX_DESC];

:o(

Please don't mess with the kernel code until you've figured how wrong
these changes are. Then give yourself a few months and read more code.

Really.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html