[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150727212206.GA8912@electric-eye.fr.zoreil.com>
Date: Mon, 27 Jul 2015 23:22:07 +0200
From: Francois Romieu <romieu@...zoreil.com>
To: Mugunthan V N <mugunthanvnm@...com>
Cc: netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for
tx packet handling for performance improvment
Mugunthan V N <mugunthanvnm@...com> :
[...]
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index d68d759..4f98537 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -752,13 +753,22 @@ static irqreturn_t cpsw_tx_interrupt(int irq, void *dev_id)
> struct cpsw_priv *priv = dev_id;
>
> cpdma_ctlr_eoi(priv->dma, CPDMA_EOI_TX);
> - cpdma_chan_process(priv->txch, 128);
> + writel(0, &priv->wr_regs->tx_en);
> +
> + if (netif_running(priv->ndev)) {
> + napi_schedule(&priv->napi_tx);
> + return IRQ_HANDLED;
> + }
cpsw_ndo_stop calls napi_disable: you can remove netif_running.
--
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists