[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150727143845.7f5c3a26@urahara>
Date: Mon, 27 Jul 2015 14:38:45 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Jiri Pirko <jiri@...nulli.us>
Cc: Steffen Klassert <steffen.klassert@...unet.com>,
netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] iproute2: Add support for IPv6 VTI tunnels to
ip6tunnel
On Thu, 2 Oct 2014 11:11:40 +0200
Jiri Pirko <jiri@...nulli.us> wrote:
> Thu, Oct 02, 2014 at 10:48:20AM CEST, steffen.klassert@...unet.com wrote:
> >On Thu, Oct 02, 2014 at 10:41:09AM +0200, Jiri Pirko wrote:
> >> Fri, Sep 26, 2014 at 09:10:56AM CEST, steffen.klassert@...unet.com wrote:
> >> >
> >> >@@ -459,11 +462,14 @@ static int do_add(int cmd, int argc, char **argv)
> >> > switch (p.proto) {
> >> > case IPPROTO_IPIP:
> >> > case IPPROTO_IPV6:
> >> >+ if (p.i_flags != VTI_ISVTI)
> >> >+ return tnl_add_ioctl(cmd, "ip6_vti0", p.name, &p);
> >> ^ Wouldn't it be more
> >> consistent to not to use
> >> the underscore?
> >
> >The ipv4 version of vti uses ip_vti0, so I tried to be consistent
> >with that.
>
> Okay, fine with me.
Sure, applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists