[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9B0331B6EBBD0E4684FBFAEDA55776F919405E0B@HASMSX110.ger.corp.intel.com>
Date: Mon, 27 Jul 2015 06:17:22 +0000
From: "Rosen, Rami" <rami.rosen@...el.com>
To: Jiri Pirko <jiri@...nulli.us>, Scott Feldman <sfeldma@...il.com>
CC: Netdev <netdev@...r.kernel.org>,
"David S. Miller" <davem@...emloft.net>,
"idosch@...lanox.com" <idosch@...lanox.com>,
"eladr@...lanox.com" <eladr@...lanox.com>,
"ogerlitz@...lanox.com" <ogerlitz@...lanox.com>,
Roopa Prabhu <roopa@...ulusnetworks.com>,
Florian Fainelli <f.fainelli@...il.com>,
Thomas Graf <tgraf@...g.ch>,
Alexei Starovoitov <ast@...mgrid.com>,
Jamal Hadi Salim <jhs@...atatu.com>,
Daniel Borkmann <daniel@...earbox.net>,
john fastabend <john.fastabend@...il.com>,
"simon.horman@...ronome.com" <simon.horman@...ronome.com>,
John Linville <linville@...driver.com>,
Andy Gospodarek <andy@...yhouse.net>,
"Shrijeet Mukherjee" <shm@...ulusnetworks.com>,
"nhorman@...driver.com" <nhorman@...driver.com>,
Jiri Pirko <jiri@...lanox.com>
Subject: RE: [patch net-next 4/4] mlxsw: Introduce Mellanox SwitchX-2 ASIC
support
Hi, Jiri,
Keep on the good work!
The .func member of the mlxsw_rx_listener object has this prototype:
void (*func)(struct sk_buff *skb, u8 local_port, u16 trap_id, void *priv);
Is the trap_id parameter needed ?
In the three use cases of .func, which are either mlxsw_emad_rx_listener_func(), mlxsw_core_event_listener_func(), or mlxsw_sx_rx_listener_func(), this parameter is not used at all.
Regards,
Rami Rosen
Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists