netdev - Re: [PATCH v2 iproute2] tc: fix bpf compilation with old glibc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGm1_kvtxPqtnMcW42H-05M6-kPYz3SZ_YUvHN11=dPR7DTqPw@mail.gmail.com>
Date:	Mon, 27 Jul 2015 10:09:47 +0200
From:	Yegor Yefremov <yegorslists@...glemail.com>
To:	Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:	Nicolas Dichtel <nicolas.dichtel@...nd.com>,
	Stephen Hemminger <shemminger@...tta.com>,
	netdev <netdev@...r.kernel.org>,
	Daniel Borkmann <daniel@...earbox.net>
Subject: Re: [PATCH v2 iproute2] tc: fix bpf compilation with old glibc

On Thu, Jul 23, 2015 at 11:50 PM, Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
> On Thu, Jul 23, 2015 at 09:17:41AM +0200, Nicolas Dichtel wrote:
>> Error was:
>> f_bpf.o: In function `bpf_parse_opt':
>> f_bpf.c:(.text+0x88f): undefined reference to `secure_getenv'
>> m_bpf.o: In function `parse_bpf':
>> m_bpf.c:(.text+0x587): undefined reference to `secure_getenv'
>> collect2: error: ld returned 1 exit status
>>
>> There is no special reason to use the secure version of getenv, thus let's
>> simply use getenv().
>>
>> CC: Daniel Borkmann <daniel@...earbox.net>
>> Fixes: 88eea5395483 ("tc: {f,m}_bpf: allow to retrieve uds path from env")
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
>> ---
>>
>> v2: rework the fix to use getenv() instead of secure_getenv()
>
> had the same workaround locally.
> Acked-by: Alexei Starovoitov <ast@...mgrid.com>

Tested-by: Yegor Yefremov <yegorslists@...glemail.com>

tested with uclibc, that has problems with secure_getenv() too.

Yegor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html