netdev - Re: [PATCH net-next] net: bcmgenet: Register link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150726.205415.573396781347754561.davem@davemloft.net>
Date:	Sun, 26 Jul 2015 20:54:15 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org, pgynther@...gle.com, jaedon.shin@...il.com
Subject: Re: [PATCH net-next] net: bcmgenet: Register link_update callback
 for all MoCA PHYs

From: Florian Fainelli <f.fainelli@...il.com>
Date: Wed, 22 Jul 2015 17:29:53 -0700

> Commit 8d88c6ebb34c ("net: bcmgenet: enable MoCA link state change
> detection") added a fixed PHY link_update callback for MoCA PHYs when
> registered using platform_data exclusively, this change is also
> applicable to systems using Device Tree as their primary configuration
> interface.
> 
> In order for this to work, move the link_update assignment into
> bcmgenet_moca_phy_setup() where we know for sure that we are running on
> a MoCA GENET instance, and do not override phydev->link since this is:
> 
> - properly taken care of by the PHY library by getting the link UP/DOWN
>   interrupts
> - this now runs everytime we call bcmgenet_open(), so we need to
>   preserve whatever we detected before we went administratively DOWN and
>   then UP
> - we need to make sure that MoCA PHYs start with a link DOWN during
>   probe in order to force a link transition to occur
> 
> To avoid a forward declaration, move bcmgenet_fixed_phy_link_update()
> above its caller.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html