netdev - Re: [patch net-next 4/4] mlxsw: Introduce Mellanox SwitchX-2 ASIC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150728180625.GA2046@nanopsycho>
Date:	Tue, 28 Jul 2015 20:06:25 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	"Rosen, Rami" <rami.rosen@...el.com>
Cc:	Scott Feldman <sfeldma@...il.com>, Netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	"idosch@...lanox.com" <idosch@...lanox.com>,
	"eladr@...lanox.com" <eladr@...lanox.com>,
	"ogerlitz@...lanox.com" <ogerlitz@...lanox.com>,
	Roopa Prabhu <roopa@...ulusnetworks.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Thomas Graf <tgraf@...g.ch>,
	Alexei Starovoitov <ast@...mgrid.com>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	Daniel Borkmann <daniel@...earbox.net>,
	john fastabend <john.fastabend@...il.com>,
	"simon.horman@...ronome.com" <simon.horman@...ronome.com>,
	John Linville <linville@...driver.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	Shrijeet Mukherjee <shm@...ulusnetworks.com>,
	"nhorman@...driver.com" <nhorman@...driver.com>,
	Jiri Pirko <jiri@...lanox.com>
Subject: Re: [patch net-next 4/4] mlxsw: Introduce Mellanox SwitchX-2 ASIC
 support

Mon, Jul 27, 2015 at 08:17:22AM CEST, rami.rosen@...el.com wrote:
>Hi, Jiri,
>
>Keep on the good work!
>
>The .func  member of the mlxsw_rx_listener object has this prototype:
>void (*func)(struct sk_buff *skb, u8 local_port, u16 trap_id, void *priv);
>
>Is the trap_id  parameter needed ?
>In the three use cases of .func, which are either mlxsw_emad_rx_listener_func(), mlxsw_core_event_listener_func(), or mlxsw_sx_rx_listener_func(), this parameter is not used at all.

You are right. We intended to use MLXSW_TRAP_ID_DONT_CARE and use
trap_id in the callback, but when user registers a callback for exact
trap_id, this is not needed. Will remove in v2.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html