netdev - Re: [PATCH net-next v3] af_mpls: fix undefined reference to ip6_route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150727.212041.2269026145203619118.davem@davemloft.net>
Date:	Mon, 27 Jul 2015 21:20:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	roopa@...ulusnetworks.com
Cc:	tgraf@...g.ch, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3] af_mpls: fix undefined reference to
 ip6_route_output

From: Roopa Prabhu <roopa@...ulusnetworks.com>
Date: Mon, 27 Jul 2015 17:41:17 -0700

> @@ -33,4 +33,11 @@ config MPLS_IPTUNNEL
>  	---help---
>  	 mpls ip tunnel support.
>  
> +config MPLS_NEXTHOP_DEVLOOKUP
> +	bool "MPLS: nexthop oif dev lookup"
> +	depends on MPLS_ROUTING && INET && (IPV6 || IPV6=n)
> +	---help---
> +	 This enables mpls route nexthop dev lookup when oif is not
> +	 specified by user


This still allows the illegal combination, how did you test this?

CONFIG_IPV6=m
CONFIG_MPLS=y
CONFIG_NET_MPLS_GSO=y
CONFIG_MPLS_ROUTING=y
CONFIG_MPLS_IPTUNNEL=y
CONFIG_MPLS_NEXTHOP_DEVLOOKUP=y

net/built-in.o: In function `find_outdev':
af_mpls.c:(.text+0x17df41): undefined reference to `ip6_route_output'

The situation that must be prevented is MPLS_ROUTING=y + IPV6=m,
but that's exactly what is being allowed even after your patch.

Again, how did you test this?  Did you try the case that causes
problems as indicated in the failure reports?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html