netdev - Re: [PATCH] Drivers: isdn: Drop unnecessary continue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1507281046530.2343@hadrien>
Date:	Tue, 28 Jul 2015 10:47:39 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Shraddha Barke <shraddha.6596@...il.com>
cc:	Karsten Keil <isdn@...ux-pingi.de>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Drivers: isdn: Drop unnecessary continue

The patch should have v2 in the subject line, and should have a
description of the change since the previous version under the ---

On Tue, 28 Jul 2015, Shraddha Barke wrote:

> The semantic patch used to make this change is :
>
> @@
> @@
> for (...;...;...) {
>   ...
>   if (...) {
>     ...
> -   continue;
>   }
> }
>
> Signed-off-by: Shraddha Barke <shraddha.6596@...il.com>
> ---
>  drivers/isdn/hardware/mISDN/hfcsusb.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c
> index 114f3bc..91beb83 100644
> --- a/drivers/isdn/hardware/mISDN/hfcsusb.c
> +++ b/drivers/isdn/hardware/mISDN/hfcsusb.c
> @@ -1921,10 +1921,9 @@ hfcsusb_probe(struct usb_interface *intf, const struct usb_device_id *id)
>  		if ((le16_to_cpu(dev->descriptor.idVendor)
>  		     == hfcsusb_idtab[i].idVendor) &&
>  		    (le16_to_cpu(dev->descriptor.idProduct)
> -		     == hfcsusb_idtab[i].idProduct)) {
> +		     == hfcsusb_idtab[i].idProduct))
>  			vend_idx = i;
> -			continue;
> -		}
> +

There is no need to add a blank line here.

julia

>  	}
>
>  	printk(KERN_DEBUG
> --
> 2.1.0
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html