netdev - RE: [PATCH net 1/2] r8152: add pre_reset and post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Jul 2015 09:52:15 +0000
From:	Hayes Wang <hayeswang@...ltek.com>
To:	Oliver Neukum <oneukum@...e.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	nic_swsd <nic_swsd@...ltek.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: RE: [PATCH net 1/2] r8152: add pre_reset and post_reset

Oliver Neukum [mailto:oneukum@...e.com]
> Sent: Tuesday, July 28, 2015 4:53 PM
[...]
> > +		return 0;
> > +
> > +	netdev = tp->netdev;
> > +	if (!netif_running(netdev))
> > +		return 0;
> > +
> > +	ret = usb_autopm_get_interface(intf);
> > +	if (ret < 0)
> > +		return ret;
> 
> What sense does this make?
> 
[...]
> > +		return 0;
> > +
> > +	netdev = tp->netdev;
> > +	if (!netif_running(netdev))
> > +		return 0;
> > +
> > +	ret = usb_autopm_get_interface(intf);
> 
> The device will be awake.

I don't sure if the device would be in runtimesuspend, so I wake it up by myself.
I think you mean I don't have to do this. I would remove them and resend the
patch. Thanks.

Best Regards,
Hayes