netdev - Re: [PATCH net-next v4] af_mpls: fix undefined reference to ip6_route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1438088676.25794.19.camel@stressinduktion.org>
Date:	Tue, 28 Jul 2015 15:04:36 +0200
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Roopa Prabhu <roopa@...ulusnetworks.com>, davem@...emloft.net,
	tgraf@...g.ch
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v4] af_mpls: fix undefined reference to
 ip6_route_output

On Mon, 2015-07-27 at 23:40 -0700, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@...ulusnetworks.com>
> 
> Undefined reference to ip6_route_output and ip_route_output
> was reported with CONFIG_INET=n and CONFIG_IPV6=n.
> 
> This patch adds new CONFIG_MPLS_NEXTHOP_DEVLOOKUP
> to lookup nexthop device if user has not specified it
> in RTA_OIF attribute. Make CONFIG_MPLS_NEXTHOP_DEVLOOKUP
> depend on INET and (IPV6 || IPV6=n) because it
> uses ip6_route_output and ip_route_output.
> 
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Reported-by: Thomas Graf <tgraf@...g.ch>
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
> ---
> 
> v1 - v2: use IS_BUILTIN
> 
> v2 - v3: Use new Kconfig option that depends on (IPV6 || IPV6=n) as
> 	 suggested by Dave. Also uses IS_ERR as suggested by Thomas.
> 
> v3 - v4: Include missed case of (MPLS_ROUTING=y && IPV6=m) reported by
>          Dave.
> 
>  net/mpls/Kconfig   |    8 ++++++++
>  net/mpls/af_mpls.c |   19 ++++++++++++++++++-
>  2 files changed, 26 insertions(+), 1 deletion(-)
> 
> diff --git a/net/mpls/Kconfig b/net/mpls/Kconfig
> index 5c467ef..134764e 100644
> --- a/net/mpls/Kconfig
> +++ b/net/mpls/Kconfig
> @@ -33,4 +33,12 @@ config MPLS_IPTUNNEL
>  	---help---
>  	 mpls ip tunnel support.
>  
> +config MPLS_NEXTHOP_DEVLOOKUP
> +	bool "MPLS: nexthop oif dev lookup"
> +	depends on MPLS_ROUTING && INET && \
> +		((IPV6 && !(MPLS_ROUTING=y && IPV6=m)) || IPV6=n)
> +	---help---
> +	 This enables mpls route nexthop dev lookup when oif is not
> +	 specified by user
> +

Urks.

Can't you simply use ipv6_stub_impl.ipv6_dst_lookup with sk=NULL to do
that and don't have a run-time dependency on IPv6 at all (for the cost
of a function pointer). Maybe same for IPv4?

If builtin you can inline those calls anyway.

Bye,
Hannes


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html