netdev - Re: [PATCH net-next v2] gianfar: Fix warnings when built on 64-bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1438185961.2993.335.camel@freescale.com>
Date:	Wed, 29 Jul 2015 11:06:01 -0500
From:	Scott Wood <scottwood@...escale.com>
To:	Claudiu Manoil <claudiu.manoil@...escale.com>
CC:	<netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>,
	<arnd@...db.de>
Subject: Re: [PATCH net-next v2] gianfar: Fix warnings when built on 64-bit

On Wed, 2015-07-29 at 16:13 +0300, Claudiu Manoil wrote:
> From: Scott Wood <scottwood@...escale.com>
> 
> As part of defconfig consolidation using fragments, we'd like to be
> able to have the same drivers enabled on 32-bit and 64-bit.  Gianfar
> happens to only exist on 32-bit systems, and when building the
> resulting 64-bit kernel warnings were produced.
> 
> A couple of the warnings are trivial, but the rfbptr code has deeper
> issues.  It uses the virtual address as the DMA address, which again,
> happens to work in the environments where this driver is currently
> used, but is not the right thing to do.
> 
> Fixes: 45b679c9a3cc ("gianfar: Implement PAUSE frame generation
> support")
> Signed-off-by: Scott Wood <scottwood@...escale.com>
> Signed-off-by: Claudiu Manoil <claudiu.manoil@...escale.com>
> 
> ---
> v2 - rebased/reworked on top of net-next (instead of net);
>    - removed CONFIG_PM unrelated change;

Are you going to submit the CONFIG_PM change separately?  It fixes a warning 
when CONFIG_PM is not enabled.

-Scott

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html