netdev - Re: [PATCH 1/2] net: Export __netdev_alloc_frag() to allow gfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1438187516.20182.95.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 29 Jul 2015 18:31:56 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	WingMan Kwok <w-kwok2@...com>
Cc:	davem@...emloft.net, m-karicheri2@...com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, "Reece R. Pollack" <x0183204@...com>
Subject: Re: [PATCH 1/2] net: Export __netdev_alloc_frag() to allow gfp_mask
 flags

On Wed, 2015-07-29 at 11:10 -0400, WingMan Kwok wrote:
> This patch makes the function __netdev_alloc_frag() non-static and
> exports it so that drivers that need to specify additional flags,
> such as __GFP_DMA, can use it. The currently exported function,
> netdev_alloc_frag() doesn't allow passing in gfp_mask flags.
> 
> Signed-off-by: WingMan Kwok <w-kwok2@...com>
> Signed-off-by: Reece R. Pollack <x0183204@...com>
> ---
>  include/linux/skbuff.h |    1 +
>  net/core/skbuff.c      |    3 ++-
>  2 files changed, 3 insertions(+), 1 deletion(-)

You can not do this.

__napi_alloc_frag() uses __alloc_page_frag() using a per cpu reserve.

This per cpu reserve would be shared by regular GFP_ATOMIC and your
__GFP_DMA allocations.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html