| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20150729.122123.754536415828052026.davem@davemloft.net> Date: Wed, 29 Jul 2015 12:21:23 -0700 (PDT) From: David Miller <davem@...emloft.net> To: makita.toshiaki@....ntt.co.jp Cc: stephen@...workplumber.org, bridge@...ts.linux-foundation.org, netdev@...r.kernel.org, ivecera@...hat.com Subject: Re: [PATCH net] bridge: Fix network header pointer for vlan tagged packets From: Toshiaki Makita <makita.toshiaki@....ntt.co.jp> Date: Tue, 28 Jul 2015 19:05:37 +0900 > There are several devices that can receive vlan tagged packets with > CHECKSUM_PARTIAL like tap, possibly veth and xennet. > When (multiple) vlan tagged packets with CHECKSUM_PARTIAL are forwarded > by bridge to a device with the IP_CSUM feature, they end up with checksum > error because before entering bridge, the network header is set to > ETH_HLEN (not including vlan header length) in __netif_receive_skb_core(), > get_rps_cpu(), or drivers' rx functions, and nobody fixes the pointer later. > > Since the network header is exepected to be ETH_HLEN in flow-dissection > and hash-calculation in RPS in rx path, and since the header pointer fix > is needed only in tx path, set the appropriate network header on forwarding > packets. > > Signed-off-by: Toshiaki Makita <makita.toshiaki@....ntt.co.jp> Applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists