netdev - Re: [PATCH] net/ipv4: suppress NETDEV_UP notification on address lifetime update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150728.233855.1081514455386990046.davem@davemloft.net>
Date:	Tue, 28 Jul 2015 23:38:55 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	david.ward@...mit.edu
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net/ipv4: suppress NETDEV_UP notification on address
 lifetime update

From: David Ward <david.ward@...mit.edu>
Date: Sun, 26 Jul 2015 12:18:58 -0400

> This notification causes the FIB to be updated, which is not needed
> because the address already exists, and more importantly it may undo
> intentional changes that were made to the FIB after the address was
> originally added. (As a point of comparison, when an address becomes
> deprecated because its preferred lifetime expired, a notification on
> this chain is not generated.)
> 
> The motivation for this commit is fixing an incompatibility between
> DHCP clients which set and update the address lifetime according to
> the lease, and a commercial VPN client which replaces kernel routes
> in a way that outbound traffic is sent only through the tunnel (and
> disconnects if any further route changes are detected via netlink).
> 
> Signed-off-by: David Ward <david.ward@...mit.edu>

Yeah, this makes sense, applied.

I bet the SCTP notifier could have ended up with dups in it's local
address list because of this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html