netdev - Re: [PATCH] packet: tpacket_snd(): fix signed/unsigned comparison

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150729.001036.271920963041164246.davem@davemloft.net>
Date:	Wed, 29 Jul 2015 00:10:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	al.drozdov@...il.com
Cc:	dborkman@...hat.com, edumazet@...gle.com, willemb@...gle.com,
	viro@...iv.linux.org.uk, eyal.birger@...il.com, mst@...hat.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] packet: tpacket_snd(): fix signed/unsigned comparison

From: Alexander Drozdov <al.drozdov@...il.com>
Date: Tue, 28 Jul 2015 13:57:01 +0300

> tpacket_fill_skb() can return a negative value (-errno) which
> is stored in tp_len variable. In that case the following
> condition will be (but shouldn't be) true:
> 
> tp_len > dev->mtu + dev->hard_header_len
> 
> as dev->mtu and dev->hard_header_len are both unsigned.
> 
> That may lead to just returning an incorrect EMSGSIZE errno
> to the user.
> 
> Signed-off-by: Alexander Drozdov <al.drozdov@...il.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html