netdev - Re: [PATCH V4 7/7] Drivers: hv: vmbus: disable local interrupt when hvsock's callback is running

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150729.152809.1531386671239230150.davem@davemloft.net>
Date:	Wed, 29 Jul 2015 15:28:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	decui@...rosoft.com
Cc:	gregkh@...uxfoundation.org, stephen@...workplumber.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	driverdev-devel@...uxdriverproject.org, olaf@...fle.de,
	apw@...onical.com, jasowang@...hat.com, kys@...rosoft.com,
	pebolle@...cali.nl, stefanha@...hat.com, vkuznets@...hat.com,
	dan.carpenter@...cle.com
Subject: Re: [PATCH V4 7/7] Drivers: hv: vmbus: disable local interrupt
 when hvsock's callback is running

From: Dexuan Cui <decui@...rosoft.com>
Date: Tue, 28 Jul 2015 05:35:30 -0700

> In the SMP guest case, when the per-channel callback hvsock_events() is
> running on virtual CPU A, if the guest tries to close the connection on
> virtual CPU B: we invoke vmbus_close() -> vmbus_close_internal(),
> then we can have trouble: on B, vmbus_close_internal() will send IPI
> reset_channel_cb() to A, trying to set channel->onchannel_callbackto NULL;
> on A, if the IPI handler happens between
> "if (channel->onchannel_callback != NULL)" and invoking
> channel->onchannel_callback, we'll invoke a function pointer of NULL.
> 
> This is why the patch is necessary.
> 
> Signed-off-by: Dexuan Cui <decui@...rosoft.com>

Sorry, I do not accept that you must use conditional locking and/or
IRQ disabling.

Boil it down to what is necessary for the least common denominator,
and use that unconditionally.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html