netdev - Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory terminologies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55B8BB29.3000202@citrix.com>
Date:	Wed, 29 Jul 2015 12:38:17 +0100
From:	David Vrabel <david.vrabel@...rix.com>
To:	Julien Grall <julien.grall@...rix.com>,
	Wei Liu <wei.liu2@...rix.com>
CC:	<linux-fbdev@...r.kernel.org>, "H. Peter Anvin" <hpa@...or.com>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	<stefano.stabellini@...citrix.com>,
	"Russell King" <linux@....linux.org.uk>,
	<linux-scsi@...r.kernel.org>, <x86@...nel.org>,
	Tomi Valkeinen <tomi.valkeinen@...com>,
	Jiri Slaby <jslaby@...e.com>, <xen-devel@...ts.xenproject.org>,
	"Jean-Christophe Plagniol-Villard" <plagnioj@...osoft.com>,
	<linux-input@...r.kernel.org>, <ian.campbell@...rix.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	Ingo Molnar <mingo@...hat.com>,
	<linux-arm-kernel@...ts.infradead.org>,
	Juergen Gross <jgross@...e.com>,
	"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linuxppc-dev@...ts.ozlabs.org>,
	Roger Pau Monné <roger.pau@...rix.com>
Subject: Re: [Xen-devel] [PATCH 4/8] xen: Use the correctly the Xen memory
 terminologies

On 29/07/15 12:35, Julien Grall wrote:
> Hi Wei,
> 
> On 29/07/15 11:13, Wei Liu wrote:
>> On Tue, Jul 28, 2015 at 04:02:45PM +0100, Julien Grall wrote:
>> [...]
>>> diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
>>> index 7d50711..3b7b7c3 100644
>>> --- a/drivers/net/xen-netback/netback.c
>>> +++ b/drivers/net/xen-netback/netback.c
>>> @@ -314,7 +314,7 @@ static void xenvif_gop_frag_copy(struct xenvif_queue *queue, struct sk_buff *skb
>>>  		} else {
>>>  			copy_gop->source.domid = DOMID_SELF;
>>>  			copy_gop->source.u.gmfn =
>>> -				virt_to_mfn(page_address(page));
>>> +				virt_to_gfn(page_address(page));
>>>  		}
>>>  		copy_gop->source.offset = offset;
>>>  
>>> @@ -1284,7 +1284,7 @@ static void xenvif_tx_build_gops(struct xenvif_queue *queue,
>>>  		queue->tx_copy_ops[*copy_ops].source.offset = txreq.offset;
>>>  
>>>  		queue->tx_copy_ops[*copy_ops].dest.u.gmfn =
>>> -			virt_to_mfn(skb->data);
>>> +			virt_to_gfn(skb->data);
>>>  		queue->tx_copy_ops[*copy_ops].dest.domid = DOMID_SELF;
>>>  		queue->tx_copy_ops[*copy_ops].dest.offset =
>>>  			offset_in_page(skb->data);
>>
>> Reviewed-by: Wei Liu <wei.liu2@...rix.com>
>>
>> One possible improvement is to change gmfn in copy_gop to gfn as well.
>> But that's outside of netback code.
> 
> The structure gnttab_copy is part of the hypervisor interface. Is it
> fine to differ on the naming between Xen and Linux?
> 
> Or maybe we could do the change in the public headers in Xen repo too.
> Is it fine to do field renaming in public headers?

I think this series should not alter than Xen API.

David
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html