netdev - Re: [PATCH] ARCNET: fix hard_header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150730.111636.2181952489319443707.davem@davemloft.net>
Date:	Thu, 30 Jul 2015 11:16:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	m.grzeschik@...gutronix.de
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...gutronix.de
Subject: Re: [PATCH] ARCNET: fix hard_header_len limit

From: Michael Grzeschik <m.grzeschik@...gutronix.de>
Date: Thu, 30 Jul 2015 15:34:36 +0200

> The commit <9c7077622dd9> ("packet: make packet_snd fail on len smaller
> than l2 header") adds the check for minimum packet length of the used l2.
> For arcnet the hardware header length is not the complete archdr which
> includes hard + soft header. This patch changes the length to
> sizeof(arc_hardware).
> 
> Signed-off-by: Michael Grzeschik <m.grzeschik@...gutronix.de>

The hard header len is used for other purposes as well, are you sure
those don't get broken by this change?

Code assumes that if the data at the SKB mac pointer is taken, for
dev->hard_header_len bytes, that is exactly the link layer header.
And that this can be used to compare two MAC headers, copy the
MAC header from one packet to another, etc.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html