netdev - Re: [PATCH net-next] r8169:Place dma_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150730.134525.824837450657122732.davem@davemloft.net>
Date:	Thu, 30 Jul 2015 13:45:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	corcodel.marian@...il.com
Cc:	netdev@...r.kernel.org, romieu@...zoreil.com
Subject: Re: [PATCH net-next] r8169:Place dma_alloc_coherent on interrupt
 context

From: Corcodel Marian <corcodel.marian@...il.com>
Date: Thu, 30 Jul 2015 22:33:21 +0300

>    According to this doc
>  https://www.kernel.org/doc/Documentation/DMA-API.txt   dma_alloc_coherent
>  must run on interrupt context, and flush the chip before use.
> 
> Signed-off-by: Corcodel Marian <corcodel.marian@...il.com>
> 
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 3df51fa..edce264 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -7535,15 +7535,15 @@ static void rtl8169_down(struct net_device *dev)
>  	rtl_pll_power_down(tp);
>  }
>  
> -static int rtl8169_close(struct net_device *dev)
> +/*static int rtl8169_close(struct net_device *dev)

This really isn't acceptable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html