netdev - Re: [PATCHv3] net/ipv6: add sysctl option accept_ra_min_hop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPwn2JR=_6NY0T4p6h1VVU77h3y3CiFEdexJ0LJL3sq62V+bew@mail.gmail.com>
Date:	Thu, 30 Jul 2015 10:31:34 +0800
From:	Hangbin Liu <liuhangbin@...il.com>
To:	YOSHIFUJI Hideaki <hideaki.yoshifuji@...aclelinux.com>
Cc:	network dev <netdev@...r.kernel.org>,
	Hannes Frederic Sowa <hannes@...essinduktion.org>
Subject: Re: [PATCHv3] net/ipv6: add sysctl option accept_ra_min_hop_limit

2015-07-30 8:45 GMT+08:00 YOSHIFUJI Hideaki
<hideaki.yoshifuji@...aclelinux.com>:

>>> How about ignoring hop limit without message is configured value is
>>> larger than 255, BTW?
>>
>> Although set accept_ra_min_hop_limit great than 255 is meaningless,  there
>> is also no need to check it since icmp6_hop_limit will not larger than 255. so
>>
>> +               if (in6_dev->cnf.accept_ra_min_hop_limit <= 255 &&
>> +                   in6_dev->cnf.accept_ra_min_hop_limit <=
>> ra_msg->icmph.icmp6_hop_limit )
>>                         in6_dev->cnf.hop_limit = ra_msg->icmph.icmp6_hop_limit;
>>
>> is  duplicated check. How do you think?
>
> How about checking in6_dev->cnf.accept_ra_min_hop_limit by outer if, then?
>
>
> if (in6_dev->cnf.accept_ra_min_hop_limit < 256 &&
>     ra_msg->icmph.icmp6_hop_limit) {
> ...
> }

Then let's move all the if check outside, I will send a v4 patch for you review.

Thanks
Hangbin
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html