netdev - Re: [PATCH net-next v5 0/2] af_mpls: fix undefined reference to ip6_route_output with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150729.224223.1592092790674598920.davem@davemloft.net>
Date:	Wed, 29 Jul 2015 22:42:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	roopa@...ulusnetworks.com
Cc:	tgraf@...g.ch, hannes@...essinduktion.org, rshearma@...cade.com,
	stephen@...workplumber.org, kuznet@....inr.ac.ru,
	jon.maloy@...csson.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v5 0/2] af_mpls: fix undefined reference to
 ip6_route_output with CONFIG_IPV6=n

From: Roopa Prabhu <roopa@...ulusnetworks.com>
Date: Tue, 28 Jul 2015 15:27:39 -0700

> v4 - v5: Use ipv6_stub_impl.ipv6_dst_lookup as suggested by Hannes

I think this might not work.

The ipv6_stub pointer is NULL until the ipv6 module is loaded.

VXLAN can safely call through ipv6_stub->foo() because it _knows_ the
ipv6 module has been loaded, and will not go away, because it is
working with an ipv6 socket.

You don't have that set of preconditions here, and thus it is pretty
easy to generate a scenerio where ipv6_stub will be NULL at your call
sites.

This is starting to get really messy, to be honest.  And we've been
harboring this build failure for several days now.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html