lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 01 Aug 2015 00:33:39 +0200 From: Daniel Borkmann <daniel@...earbox.net> To: Cong Wang <xiyou.wangcong@...il.com> CC: Linux Kernel Network Developers <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>, Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang <cwang@...pensource.com> Subject: Re: [Patch net] act_mirred: avoid calling tcf_hash_release() when binding On 08/01/2015 12:25 AM, Cong Wang wrote: > On Fri, Jul 31, 2015 at 3:06 AM, Daniel Borkmann <daniel@...earbox.net> wrote: >> Did you test all variants on this? >> >> I.e. what happens when you replace an existing one, I think the >> refcnt should also be dropped here. It looks like we only drop >> it, in case we tried to add an action to an already existing index ... > > Yeah, clearly the replace case is anti-pattern too, like you showed. > > But that is a different bug, right? Since 'bind' is independent of > 'replace'. As in $subject, my patch only fixes the binding case. > I will send a following patch to fix replace case. I wasn't aware you planned to send an extra patch for the other issue, probably not worth the split, but I don't mind. Thanks, Daniel -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists