netdev - Re: [PATCH net] stmmac: fix missing MODULE_LICENSE in stmmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150731.154344.288497588136948900.davem@davemloft.net>
Date:	Fri, 31 Jul 2015 15:43:44 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	manabian@...il.com
Cc:	peppe.cavallaro@...com, i.gnatenko.brain@...il.co,
	netdev@...r.kernel.org, maxime.ripard@...ndra.org
Subject: Re: [PATCH net] stmmac: fix missing MODULE_LICENSE in
 stmmac_platform

From: Joachim Eastwood <manabian@...il.com>
Date: Fri, 31 Jul 2015 19:02:32 +0200

> Commit 50649ab14982 ("stmmac: drop driver from stmmac platform code")
> was a bit overzealous in removing code and dropped the MODULE_*
> macro's that are still needed since stmmac_platform can be a module.
> Fix this by putting the macro's remvoed in 50649ab14982 back.
> 
> This fixes the following errors when used as a module:
>   stmmac_platform: module license 'unspecified' taints kernel.
>   Disabling lock debugging due to kernel taint
>   stmmac_platform: Unknown symbol devm_kmalloc (err 0)
>   stmmac_platform: Unknown symbol stmmac_suspend (err 0)
>   stmmac_platform: Unknown symbol platform_get_irq_byname (err 0)
>   stmmac_platform: Unknown symbol stmmac_dvr_remove (err 0)
>   stmmac_platform: Unknown symbol platform_get_resource (err 0)
>   stmmac_platform: Unknown symbol of_get_phy_mode (err 0)
>   stmmac_platform: Unknown symbol of_property_read_u32_array (err 0)
>   stmmac_platform: Unknown symbol of_alias_get_id (err 0)
>   stmmac_platform: Unknown symbol stmmac_resume (err 0)
>   stmmac_platform: Unknown symbol stmmac_dvr_probe (err 0)
> 
> Fixes: 50649ab14982 ("stmmac: drop driver from stmmac platform code")
> Reported-by: Igor Gnatenko <i.gnatenko.brain@...il.com>
> Signed-off-by: Joachim Eastwood <manabian@...il.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html