netdev - Re: [PATCH net-next] vxlan: expose COLLECT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150731080019.GB4738@pox.localdomain>
Date:	Fri, 31 Jul 2015 10:00:19 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Alexei Starovoitov <ast@...mgrid.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] vxlan: expose COLLECT_METADATA flag to user
 space

On 07/30/15 at 08:10pm, Alexei Starovoitov wrote:
> Two vxlan driver flags FLOWBASED and COLLECT_METADATA need to be set to
> make use of its new flow mode. The former already exposed. Expose the latter.
> 
> Signed-off-by: Alexei Starovoitov <ast@...mgrid.com>

Since you are analyzing the program when you load it. Could you call
ip_tunnel_need_metadata() when we load a program which accesses
the new metadata field and ip_tunnel_unneed_metadata() when you unload
it? This would hide the need to set this flag from the user. The con
is that it enables metadata on all net_devices.

I'm also fine with exposing this flag to the user though. I'll leave it
up to you so feel free to add my ack if you want to go this route.

Acked-by: Thomas Graf <tgraf@...g.ch>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html