netdev - RE: [PATCH][v2] net: phy: add driver for aquantia phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 31 Jul 2015 02:01:38 +0000
From:	Shaohui Xie <Shaohui.Xie@...escale.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"f.fainelli@...il.com" <f.fainelli@...il.com>
Subject: RE: [PATCH][v2] net: phy: add driver for aquantia phy

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Friday, July 31, 2015 6:55 AM
> To: shh.xie@...il.com
> Cc: netdev@...r.kernel.org; f.fainelli@...il.com; Xie Shaohui-B21989
> Subject: Re: [PATCH][v2] net: phy: add driver for aquantia phy
> 
> From: <shh.xie@...il.com>
> Date: Thu, 30 Jul 2015 12:17:15 +0800
> 
> > +static int aquantia_soft_reset(struct phy_device *phydev) {
> > +	return 0;
> > +}
> > +
> > +static int aquantia_config_init(struct phy_device *phydev) {
> > +	return 0;
> > +}
> 
> You shouldn't need to implement these methods at all, just leave them
> NULL in the driver struct.
> 
> The only thing implementing them as nop routines like this does is make
> the PHY fixups get scanned.  And I don't think there are any for this
> device.
[S.H] OK. Will remove the nop routines in next version.
Thanks!

Shaohui
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html