lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Jul 2015 13:14:11 -0700 From: Joe Stringer <joestringer@...ira.com> To: Hannes Frederic Sowa <hannes@...hat.com> Cc: Linux Netdev List <netdev@...r.kernel.org>, Linux Kernel <linux-kernel@...r.kernel.org>, Pablo Neira Ayuso <pablo@...filter.org>, Patrick McHardy <kaber@...sh.net>, Justin Pettit <jpettit@...ira.com>, Pravin Shelar <pshelar@...ira.com>, Andy Zhou <azhou@...ira.com>, Jesse Gross <jesse@...ira.com>, Florian Westphal <fwestpha@...hat.com>, Thomas Graf <tgraf@...ronetworks.com> Subject: Re: [PATCH net-next 5/9] openvswitch: Add conntrack action On 31 July 2015 at 08:26, Hannes Frederic Sowa <hannes@...hat.com> wrote: > On Thu, 2015-07-30 at 11:12 -0700, Joe Stringer wrote: >> +static void do_output(struct datapath *dp, struct sk_buff *skb, int >> out_port, >> + struct sw_flow_key *key) >> { >> struct vport *vport = ovs_vport_rcu(dp, out_port); >> >> - if (likely(vport)) >> - ovs_vport_send(vport, skb); >> - else >> + if (likely(vport)) { >> + unsigned int mru = OVS_CB(skb)->mru; >> + struct dst_entry *orig_dst = dst_clone(skb_dst(skb)); > > I think you forgot to remove this? You're right that it's incorrect, however we do still need to ensure that the original skb's reference to the orig_dst is released. I'll tidy this up for v2. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists