netdev - Re: ip6t_SYNPROXY crashes kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150801125444.GB18502@acer.localdomain>
Date:	Sat, 1 Aug 2015 14:54:45 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	pablo@...filter.org, netdev@...r.kernel.org
Subject: Re: ip6t_SYNPROXY crashes kernel

On 28.07, Phil Sutter wrote:
> Hi,
> 
> When synproxy_send_server_ack() calls synproxy_send_tcp(), it passes
> NULL as third parameter (struct nf_conntrack *nfct). And the first thing
> synproxy_send_tcp() does, is dereference it:
> 
> | struct net *net = nf_ct_net((struct nf_conn *)nfct);
> 
> I could not find a commit leading to this breakage in the commit log,
> which makes me doubt ip6t_SYNPROXY has ever worked at all.
> 
> If you need one, I have a reproducer at hand. (Though I would want to
> strip it down a bit first.) Just let me know.

Thanks, looks like I never tested this with netns enabled. Would you
care to provide a patch? An easy fix seems to be to pass the synproxy_net
struct to synproxy_send_tcp() and use nf_ct_net(snet->tmpl) instead.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html