netdev - Re: [Patch net] fq_codel: explicitly reset flows in ->reset()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150802.172028.327907117686065749.davem@davemloft.net>
Date:	Sun, 02 Aug 2015 17:20:28 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	xiyou.wangcong@...il.com
Cc:	netdev@...r.kernel.org, agartrell@...com, jhs@...atatu.com,
	eric.dumazet@...il.com
Subject: Re: [Patch net] fq_codel: explicitly reset flows in ->reset()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Fri, 31 Jul 2015 17:53:39 -0700

> From: Eric Dumazet <eric.dumazet@...il.com>
> 
> Alex reported the following crash when using fq_codel
> with htb:
 ...
> As Jamal pointed out, there is actually no need to call dequeue
> to purge the queued skb's in reset, data structures can be just
> reset explicitly. Therefore, we reset everything except config's
> and stats, so that we would have a fresh start after device flipping.
> 
> Fixes: 4b549a2ef4be ("fq_codel: Fair Queue Codel AQM")
> Reported-by: Alex Gartrell <agartrell@...com>
> Cc: Alex Gartrell <agartrell@...com>
> Cc: Jamal Hadi Salim <jhs@...atatu.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> [xiyou.wangcong@...il.com: added codel_vars_init() and qdisc_qstats_backlog_dec()]
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html