netdev - Re: [PATCH] r8169: Permit users to change transmit and receive max pachet size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150803.004506.1774857049576413752.davem@davemloft.net>
Date:	Mon, 03 Aug 2015 00:45:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	corcodel.marian@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] r8169: Permit users to change transmit and receive max
 pachet size

From: Corcodel Marian <corcodel.marian@...il.com>
Date: Mon,  3 Aug 2015 10:28:38 +0300

>  Realtek nic its very versatile and have more registers for
>  optimise  and solve different issues.  I added 2 parameters rx_buf_sz and
>  txpacketmax  1.Parameter rx_buf_sz represent Receive Packet Maximum size and
>  on   this program is 16383 bytes, eg RTL 8101E use 16000 and user may use  
>  alls values up to maximum but value great from zero.   If a received packet
>  of packet length larger than the value set here, then it will set  both RWT
>  and RES bits in the corresponding Rx Status Descriptor. If the packet,  which
>  is larger than the RMS value, is received without CRC error, it is still a
>  good  packet, although both RWT and RES bits are set in the corresponding Rx
>  Status  Descriptor.  2. Parameter txpacketmax represent Max Transmit Packet
>  Size value must be on  range 1-63.Do not put zero on any situation.Every
>  field from range 1-63 have  128 bytes.  For regular LAN applications, i.e.,
>  the max packet size is either 1518 or 1522 (VLAN) bytes, this field must be
>  larger than the max packet size. E.g., 0x0C. On mee working good with
>  txpacketmax=60 and rx_buf_sz=1600
> 
> Signed-off-by: Corcodel Marian <corcodel.marian@...il.com>

Sorry, such module parameters are completely inappropriate.

Control the values, at run time, using a standard, generic facility
such as ethtool.

Please stop sending patches that add new module parameters, they are
almost certainly guaranteed to be unacceptable.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html