netdev - Re: [PATCH v2] openvswitch: Fix L4 checksum handling when dealing with IP fragments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALnjE+r3sQXQ-Viw6goVY0Mb0EhFggGzR5TYkQHGUbg8tKFJ2Q@mail.gmail.com>
Date:	Mon, 3 Aug 2015 10:10:56 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Glenn Griffin <ggriffin.kernel@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	"dev@...nvswitch.org" <dev@...nvswitch.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] openvswitch: Fix L4 checksum handling when dealing
 with IP fragments

On Mon, Aug 3, 2015 at 9:56 AM, Glenn Griffin <ggriffin.kernel@...il.com> wrote:
> openvswitch modifies the L4 checksum of a packet when modifying
> the ip address. When an IP packet is fragmented only the first
> fragment contains an L4 header and checksum. Prior to this change
> openvswitch would modify all fragments, modifying application data
> in non-first fragments, causing checksum failures in the
> reassembled packet.
>
> Signed-off-by: Glenn Griffin <ggriffin.kernel@...il.com>

Looks good.
Acked-by: Pravin B Shelar <pshelar@...ira.com>

This patch needs to be backported to stable branches.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html