[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55C0C0C5.1040901@cumulusnetworks.com>
Date: Tue, 04 Aug 2015 06:40:21 -0700
From: roopa <roopa@...ulusnetworks.com>
To: Dan Carpenter <dan.carpenter@...cle.com>
CC: "David S. Miller" <davem@...emloft.net>,
"Eric W. Biederman" <ebiederm@...ssion.com>,
Robert Shearman <rshearma@...cade.com>,
Tom Herbert <tom@...bertland.com>, netdev@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: Re: [patch] mpls: small cleanup in inet/inet6_fib_lookup_dev()
On 8/4/15, 12:44 AM, Dan Carpenter wrote:
> We recently changed this code from returning NULL to returning ERR_PTR.
> There are some left over NULL assignments which we can remove. We can
> preserve the error code from ip_route_output() instead of always
> returning -ENODEV. Also these functions use a mix of gotos and direct
> returns. There is no cleanup necessary so I changed the gotos to
> direct returns.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
Acked-by: Roopa Prabhu <roopa@...ulusnetworks.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists