netdev - Re: [PATCH 8/8] can: replace timestamp as unique skb attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150804191848.GA29709@kroah.com>
Date:	Tue, 4 Aug 2015 12:18:48 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Oliver Hartkopp <socketcan@...tkopp.net>
Cc:	Marc Kleine-Budde <mkl@...gutronix.de>, netdev@...r.kernel.org,
	davem@...emloft.net, linux-can@...r.kernel.org,
	kernel@...gutronix.de, linux-stable <stable@...r.kernel.org>
Subject: Re: [PATCH 8/8] can: replace timestamp as unique skb attribute

On Mon, Jul 27, 2015 at 08:34:32PM +0200, Oliver Hartkopp wrote:
> Hello Greg,
> 
> On 12.07.2015 21:18, Marc Kleine-Budde wrote:
> >From: Oliver Hartkopp <socketcan@...tkopp.net>
> >
> >Commit 514ac99c64b "can: fix multiple delivery of a single CAN frame for
> >overlapping CAN filters" requires the skb->tstamp to be set to check for
> >identical CAN skbs.
> >
> >Without timestamping to be required by user space applications this timestamp
> >was not generated which lead to commit 36c01245eb8 "can: fix loss of CAN frames
> >in raw_rcv" - which forces the timestamp to be set in all CAN related skbuffs
> >by introducing several __net_timestamp() calls.
> >
> >This forces e.g. out of tree drivers which are not using alloc_can{,fd}_skb()
> >to add __net_timestamp() after skbuff creation to prevent the frame loss fixed
> >in mainline Linux.
> >
> >This patch removes the timestamp dependency and uses an atomic counter to
> >create an unique identifier together with the skbuff pointer.
> >
> >Btw: the new skbcnt element introduced in struct can_skb_priv has to be
> >initialized with zero in out-of-tree drivers which are not using
> >alloc_can{,fd}_skb() too.
> >
> >Signed-off-by: Oliver Hartkopp <socketcan@...tkopp.net>
> >Cc: linux-stable <stable@...r.kernel.org>
> 
> Can you please queue up this missing/lost patch for the long term 4.1.x ?
> 
> It fixes the mess with commits
> 
> 514ac99c64b "can: fix multiple delivery of a single CAN frame for
> overlapping CAN filters"
> 
> which originally fixed
> 
> 36c01245eb8 "can: fix loss of CAN frames in raw_rcv"
> 
> So finally this missing patch would bring 4.1.x into the proper state we now
> have in 4.2-rc4.
> 
> Upstream commit of this patch is:
> 
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=d3b58c47d330de8c29898fe9746f7530408f8a59

It's in my queue, I still have way over 200 commits to get through for
4.1.x, your patches are in good company.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html