netdev - Re: [PATCH net-next v2 1/2] openvswitch: Use regular GRE net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150803.215955.1031623872655808616.davem@davemloft.net>
Date:	Mon, 03 Aug 2015 21:59:55 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	alexei.starovoitov@...il.com
Cc:	pshelar@...ira.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/2] openvswitch: Use regular GRE
 net_device instead of vport

From: Alexei Starovoitov <alexei.starovoitov@...il.com>
Date: Mon, 3 Aug 2015 21:23:40 -0700

> On Mon, Aug 03, 2015 at 05:27:26PM -0700, Pravin B Shelar wrote:
>> With addition of flow based tunneling, there is no need to
>> have special GRE vport. Removes all of the OVS specific
>> GRE code and make OVS use a ip_gre net_device.
>> Minimal GRE vport is kept to handle compatibility with
>> current userspace application.
>> 
>> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>
> ...
>> +#define GRE_TAP_FB_NAME "gretap0"
> ...
>> +	/* fallback device is used for flow based tunneling. */
>> +	if (!strcmp(dev->name, GRE_TAP_FB_NAME)) {
>> +		struct ip_tunnel *t;
>> +
>> +		t = netdev_priv(dev);
>> +		t->flow_based_tunnel = true;
>> +		eth_hw_addr_random(dev);
>> +		netif_keep_dst(dev);
>> +	}
>> +
> 
> feature detection based on netdev name?
> meaning that there will be only one such device for the whole
> host? and namespaces cannot have their own gre tunnels?
> (since host 'gretap0' cannot be seen in netns)

Doing anything like this by netdev name is wrong.

Pravin you will need to do this in some other way.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html