netdev - RE: [PATCH] igb: do not re-init SR-IOV during probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 4 Aug 2015 22:15:43 +0000
From:	"Brown, Aaron F" <aaron.f.brown@...el.com>
To:	Stefan Assmann <sassmann@...nic.de>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
Subject: RE: [PATCH] igb: do not re-init SR-IOV during probe

> From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org]
> On Behalf Of Stefan Assmann
> Sent: Friday, July 10, 2015 6:01 AM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Kirsher, Jeffrey T; sassmann@...nic.de
> Subject: [PATCH] igb: do not re-init SR-IOV during probe
> 
> During driver probing the following code path is triggered.
> igb_probe
> ->igb_sw_init
>   ->igb_probe_vfs
>     ->igb_pci_enable_sriov
>       ->igb_sriov_reinit
> 
> Doing the SR-IOV re-init is not necessary during probing since we're
> starting from scratch. Here we can call igb_enable_sriov() right away.
> 
> Running igb_sriov_reinit() during igb_probe() also seems to cause
> occasional packet loss on some onboard 82576 NICs. Reproduced on
> Dell and HP servers with onboard 82576 NICs.
> Example:
> Intel Corporation 82576 Gigabit Network Connection [8086:10c9] (rev 01)
> Subsystem: Dell Device [1028:0481]
> 
> Signed-off-by: Stefan Assmann <sassmann@...nic.de>
> ---
>  drivers/net/ethernet/intel/igb/igb_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Tested-by: Aaron Brown <aaron.f.brown@...el.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html