netdev - Re: [PATCH net-next v2 1/2] openvswitch: Use regular GRE net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALnjE+ruRdOhs1=E1ZRyPdhoKFr08yqZJvh3Z21wE-yjRgg4hQ@mail.gmail.com>
Date:	Mon, 3 Aug 2015 22:58:02 -0700
From:	Pravin Shelar <pshelar@...ira.com>
To:	Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:	David Miller <davem@...emloft.net>, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v2 1/2] openvswitch: Use regular GRE net_device
 instead of vport

On Mon, Aug 3, 2015 at 10:54 PM, Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
> On Mon, Aug 03, 2015 at 10:51:02PM -0700, Pravin Shelar wrote:
>> On Mon, Aug 3, 2015 at 9:23 PM, Alexei Starovoitov
>> <alexei.starovoitov@...il.com> wrote:
>> > On Mon, Aug 03, 2015 at 05:27:26PM -0700, Pravin B Shelar wrote:
>> >> With addition of flow based tunneling, there is no need to
>> >> have special GRE vport. Removes all of the OVS specific
>> >> GRE code and make OVS use a ip_gre net_device.
>> >> Minimal GRE vport is kept to handle compatibility with
>> >> current userspace application.
>> >>
>> >> Signed-off-by: Pravin B Shelar <pshelar@...ira.com>
>> > ...
>> >> +#define GRE_TAP_FB_NAME "gretap0"
>> > ...
>> >> +     /* fallback device is used for flow based tunneling. */
>> >> +     if (!strcmp(dev->name, GRE_TAP_FB_NAME)) {
>> >> +             struct ip_tunnel *t;
>> >> +
>> >> +             t = netdev_priv(dev);
>> >> +             t->flow_based_tunnel = true;
>> >> +             eth_hw_addr_random(dev);
>> >> +             netif_keep_dst(dev);
>> >> +     }
>> >> +
>> >
>> > feature detection based on netdev name?
>> > meaning that there will be only one such device for the whole
>> > host? and namespaces cannot have their own gre tunnels?
>> > (since host 'gretap0' cannot be seen in netns)
>> >
>> gretap0 exist in every namespace. This device is created in GRE namespce init.
>
> then all of them get to be in flow_based mode without being able to
> change it?
>
Yes, But there is no side effect of this feature for the user of the device.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html