[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150805094057.59260077@urahara>
Date: Wed, 5 Aug 2015 09:40:57 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Liviu Dudau <Liviu.Dudau@....com>
Cc: Mirko Lindner <mlindner@...vell.com>,
Ryan Harkin <ryan.harkin@...aro.org>,
netdev <netdev@...r.kernel.org>,
lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sky2: Add module parameter for passing the MAC address
On Wed, 5 Aug 2015 16:50:54 +0100
Liviu Dudau <Liviu.Dudau@....com> wrote:
> For designs where EEPROMs are not connected to PCI Yukon2
> chips we need to get the MAC address from the firmware.
> Add a module parameter called 'mac_address' for this. It
> will be used if no DT node can be found and the B2_MAC
> register holds an invalid value.
>
> Signed-off-by: Liviu Dudau <Liviu.Dudau@....com>
Yes, I can see that this can be a real problem, and other drivers
solve the problem. The standard method is to assign a random mac address
(and then let scripts overwrite) rather than introducing module parameter.
Module parameters are discouraged because they are device specific.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists