[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <55C34593.8010907@cogentembedded.com>
Date: Thu, 6 Aug 2015 14:31:31 +0300
From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Johannes Berg <johannes@...solutions.net>
Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH 2/5] net: rfkill: add rfkill_find_type function
Hello.
On 8/5/2015 4:39 PM, Heikki Krogerus wrote:
> Helper for finding the type based on name. Useful if the
> type needs to be determined based on device property.
> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> ---
> include/linux/rfkill.h | 15 +++++++++++++
> net/rfkill/core.c | 57 +++++++++++++++++++++++++-------------------------
> 2 files changed, 44 insertions(+), 28 deletions(-)
> diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> index d901078..02f563c 100644
> --- a/include/linux/rfkill.h
> +++ b/include/linux/rfkill.h
[...]
> @@ -268,6 +277,12 @@ static inline bool rfkill_blocked(struct rfkill *rfkill)
> {
> return false;
> }
> +
> +static inline enum rfkill_type rfkill_find_type(const char *name)
> +{
> + return 0;
> +}
> +
Shouldn't it return some member of 'enum rfkill_type' instead?
[...]
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists