netdev - Re: [PATCH net V2] virtio-net: drop NETIF_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150806.154910.1261240005857312043.davem@davemloft.net>
Date:	Thu, 06 Aug 2015 15:49:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mst@...hat.com
Cc:	jasowang@...hat.com, virtualization@...ts.linux-foundation.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	sergei.shtylyov@...entembedded.com
Subject: Re: [PATCH net V2] virtio-net: drop NETIF_F_FRAGLIST

From: "Michael S. Tsirkin" <mst@...hat.com>
Date: Thu, 6 Aug 2015 16:13:11 +0300

> On Wed, Aug 05, 2015 at 10:34:04AM +0800, Jason Wang wrote:
>> virtio declares support for NETIF_F_FRAGLIST, but assumes
>> that there are at most MAX_SKB_FRAGS + 2 fragments which isn't
>> always true with a fraglist.
>> 
>> A longer fraglist in the skb will make the call to skb_to_sgvec overflow
>> the sg array, leading to memory corruption.
>> 
>> Drop NETIF_F_FRAGLIST so we only get what we can handle.
>> 
>> Cc: Michael S. Tsirkin <mst@...hat.com>
>> Signed-off-by: Jason Wang <jasowang@...hat.com>
> 
> I noticed only now that this didn't Cc Dave, so of course it's
> not applied.

CC:'ing me isn't the requirement. CC:'ing netdev is, which he
did.  If you check patchwork, it's there in the queue.

I'm just behind and heavily backlogged because I've been working
on other things.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html