netdev - Re: [PATCH v2] xen/netback: Wake dealloc thread after completing zerocopy work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150806.234342.1288177717422175509.davem@davemloft.net>
Date:	Thu, 06 Aug 2015 23:43:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ross.lagerwall@...rix.com
Cc:	netdev@...r.kernel.org, xen-devel@...ts.xenproject.org,
	wei.liu2@...rix.com, ian.campbell@...rix.com
Subject: Re: [PATCH v2] xen/netback: Wake dealloc thread after completing
 zerocopy work

From: Ross Lagerwall <ross.lagerwall@...rix.com>
Date: Tue, 4 Aug 2015 15:40:59 +0100

> Waking the dealloc thread before decrementing inflight_packets is racy
> because it means the thread may go to sleep before inflight_packets is
> decremented. If kthread_stop() has already been called, the dealloc
> thread may wait forever with nothing to wake it. Instead, wake the
> thread only after decrementing inflight_packets.
> 
> Signed-off-by: Ross Lagerwall <ross.lagerwall@...rix.com>
> ---
> Changed in V2: Move wakeup into zerocopy_complete function.

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html