netdev - Re: [PATCH net-next] r8169:Issues on alloc memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150807.153514.763798776089518142.davem@davemloft.net>
Date:	Fri, 07 Aug 2015 15:35:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	corcodel.marian@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] r8169:Issues on alloc memory

From: Corcodel Marian <corcodel.marian@...il.com>
Date: Wed,  5 Aug 2015 18:41:17 +0300

> +#define R8169_TX_RING_BYTES	(NUM_ARRAYS_MAX * sizeof(struct TxDesc)) /* here sizeof not reporting correct */
> +#define R8169_RX_RING_BYTES	(NUM_ARRAYS_MAX * sizeof(struct RxDesc)) /* here sizeof not reporting correct */

This comment makes the code more confusing rather than easier to
understand.

In fact I fail to see the reason for this patch, as a whole, at all.

I hate to do this, but I am explitly letting you know that I am not going
to invest any more time reviewing any submissions you make.

They are all poorly formed, lack proper complete explanations, are
buggy, or add no value at all to the driver.

And the situation is not improving.  This has been going on for several
weeks now, and I have to draw the line somewhere.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html