[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 8 Aug 2015 17:57:46 +0200
From: Patrick McHardy <kaber@...sh.net>
To: Phil Sutter <phil@....cc>
Cc: pablo@...filter.org, netdev@...r.kernel.org,
netfilter-devel@...r.kernel.org
Subject: Re: [PATCH 1/2] netfilter: ip6t_SYNPROXY: fix NULL pointer
dereference
On 06.08, Phil Sutter wrote:
> This happens when networking namespaces are enabled.
Thanks, just one minor request:
> synproxy_send_tcp(const struct sk_buff *skb, struct sk_buff *nskb,
> struct nf_conntrack *nfct, enum ip_conntrack_info ctinfo,
> struct ipv6hdr *niph, struct tcphdr *nth,
> - unsigned int tcp_hdr_size)
> + unsigned int tcp_hdr_size, struct synproxy_net *snet)
Logically the synproxy_net pointer should come before all other arguments
since its the container for a lot of the following arguments.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists