netdev - Re: [PATCH] r8169: Filtered data on Rx descriptor status context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150810192459.GA5361@electric-eye.fr.zoreil.com>
Date:	Mon, 10 Aug 2015 21:24:59 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Marian Corcodel <corcodel.marian@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] r8169: Filtered data on Rx descriptor status context

Marian Corcodel <corcodel.marian@...il.com> :
> This is specified on data sheet  only when LS  is set must evaluate
> RES   bit very important patch.Whi say no here not undestand .Please
> read Data sheet for more info.

Your patch ignores the following fact: the driver works with maximally
sized receive buffers to avoid fragmented packets - see git log for an
enlightning journey through the history of the r8169 driver.

Beyond blind datasheet compliance, have you been able to experience
FirstFrag = 0 or LastFrag = 0 receive descriptors with the current
in-kernel driver ?

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html