[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20150810.134645.320097321290649615.davem@davemloft.net>
Date: Mon, 10 Aug 2015 13:46:45 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: raj@...dy.usa.hp.com
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: add explicit logging and stat for
neighbour table overflow
From: raj@...dy.usa.hp.com (Rick Jones)
Date: Fri, 7 Aug 2015 11:10:37 -0700 (PDT)
> From: Rick Jones <rick.jones2@...com>
>
> Add an explicit neighbour table overflow message (ratelimited) and
> statistic to make diagnosing neighbour table overflows tractable in
> the wild.
>
> Diagnosing a neighbour table overflow can be quite difficult in the wild
> because there is no explicit dmesg logged. Callers to neighbour code
> seem to use net_dbg_ratelimit when the neighbour call fails which means
> the "base message" is not emitted and the callback suppressed messages
> from the ratelimiting can end-up juxtaposed with unrelated messages.
> Further, a forced garbage collection will increment a stat on each call
> whether it was successful in freeing-up a table entry or not, so that
> statistic is only a hint. So, add a net_info_ratelimited message and
> explicit statistic to the neighbour code.
>
> Signed-off-by: Rick Jones <rick.jones2@...com>
Looks fine, applied, thanks Rick.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists