netdev - Re: [PATCH v2 2/2] netfilter: ip6t_SYNPROXY: fix sending window update to client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150810080607.GC20899@acer.localdomain>
Date:	Mon, 10 Aug 2015 10:06:07 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Phil Sutter <phil@....cc>
Cc:	pablo@...filter.org, netdev@...r.kernel.org,
	netfilter-devel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] netfilter: ip6t_SYNPROXY: fix sending window
 update to client

On 09.08, Phil Sutter wrote:
> This is the identical fix as "netfilter: ipt_SYNPROXY: fix sending
> window update to client" but for the IPv6 variant which obviously
> suffers from the same issue.

Looks fine to me.

Acked-by: Patrick McHardy <kaber@...sh.net>

(Also for the IPv4 version, which for some reason I didn't receive)

> 
> Signed-off-by: Phil Sutter <phil@....cc>
> ---
> Changes since v1:
> - Adjust for v2 changes of first patch.
> ---
>  net/ipv6/netfilter/ip6t_SYNPROXY.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/netfilter/ip6t_SYNPROXY.c b/net/ipv6/netfilter/ip6t_SYNPROXY.c
> index bcebc24..ebbb754 100644
> --- a/net/ipv6/netfilter/ip6t_SYNPROXY.c
> +++ b/net/ipv6/netfilter/ip6t_SYNPROXY.c
> @@ -243,7 +243,8 @@ synproxy_send_client_ack(const struct synproxy_net *snet,
>  
>  	synproxy_build_options(nth, opts);
>  
> -	synproxy_send_tcp(snet, skb, nskb, NULL, 0, niph, nth, tcp_hdr_size);
> +	synproxy_send_tcp(snet, skb, nskb, skb->nfct, IP_CT_ESTABLISHED_REPLY,
> +	                  niph, nth, tcp_hdr_size);
>  }
>  
>  static bool
> -- 
> 2.1.2
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html