netdev - Re: [PATCH 08/10] ss: symmetrical subhandler output extension example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55C896BA.8040408@cogentembedded.com>
Date:	Mon, 10 Aug 2015 15:19:06 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Matthias Tafelmeier <matthias.tafelmeier@....net>,
	netdev@...r.kernel.org
Cc:	hagen@...u.net, shemminger@...l.org, fw@...len.de,
	edumazet@...gle.com, daniel@...earbox.net
Subject: Re: [PATCH 08/10] ss: symmetrical subhandler output extension example

On 8/10/2015 2:13 AM, Matthias Tafelmeier wrote:

> This small sized patch shall convey the locations which have to be
> changed for a symmetrical output extension. Symmetrical means in this
> context all existing semantically related handlers in the diverse
> formatters (for hr and json up to now).

> Signed-off-by: Matthias Tafelmeier <matthias.tafelmeier@....net>
> Suggested-by: Hagen Paul Pfeifer <hagen@...u.net>

[...]

> diff --git a/misc/ss_json_fmt.c b/misc/ss_json_fmt.c
> index f1a53cd..e80f063 100644
> --- a/misc/ss_json_fmt.c
> +++ b/misc/ss_json_fmt.c
> @@ -161,7 +161,9 @@ static void tcp_stats_json_fmt(struct tcpstat *s)
>   	if (s->rcv_rtt) {
>   		printf(",\n%s\"rcv_rtt\": %g", indent1, s->rcv_rtt);
>   	}
> -
> +	if (s->rcv_space) {
> +		printf(",\n%s\"rcv_space\": %d", indent1, s->rcv_space);
> +	}

    {} not needed. I guess you haven't run your patches thru 
scripts/checkpatch.pl?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html