netdev - Re: [PATCH 3.14] net: sysctl_net_core: remove compiler warning about unused variable 'one'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55C9FE7E.9050302@gmail.com>
Date:	Tue, 11 Aug 2015 15:54:06 +0200
From:	Dirk Behme <dirk.behme@...il.com>
To:	Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	"David S. Miller" <davem@...emloft.net>,
	Dirk Behme <dirk.behme@...bosch.com>, netdev@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH 3.14] net: sysctl_net_core: remove compiler warning about
 unused variable 'one'

On 11.08.2015 14:42, Vladimir Zapolskiy wrote:
> From: Dirk Behme <dirk.behme@...bosch.com>
>
> Remove the compiler warning
>
>    net/core/sysctl_net_core.c:26:12: warning: 'one' defined but not used [-Wunused-variable]
>       static int one = 1;
>
> introduced by the 3.14.37 stable commit a1d55b36de6bf2 ("net: sysctl_net_core:
> check SNDBUF and RCVBUF for min length") which made 'one' obsolete (in
> contrast to recent mainline kernel, which still uses 'one').
>
> Signed-off-by: Dirk Behme <dirk.behme@...bosch.com>
> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
> Cc: <netdev@...r.kernel.org>
> Cc: <stable@...r.kernel.org> # 3.14.x-
> Fixes: a1d55b36de6b ("net: sysctl_net_core: check SNDBUF and RCVBUF for min length")


It seems that this has been sent previously and was rejected:

http://www.spinics.net/lists/stable/msg87281.html

http://www.spinics.net/lists/stable/msg87282.html

Best regards

Dirk

> ---
>   net/core/sysctl_net_core.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c
> index e731c96..8725b91 100644
> --- a/net/core/sysctl_net_core.c
> +++ b/net/core/sysctl_net_core.c
> @@ -23,7 +23,6 @@
>   #include <net/pkt_sched.h>
>
>   static int zero = 0;
> -static int one = 1;
>   static int ushort_max = USHRT_MAX;
>   static int min_sndbuf = SOCK_MIN_SNDBUF;
>   static int min_rcvbuf = SOCK_MIN_RCVBUF;
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html