netdev - Re: [PATCH net] net: dsa: Do not override PHY interface if already configured

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55CBBBD4.1080803@gmail.com>
Date:	Wed, 12 Aug 2015 14:34:12 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, andrew@...n.ch, linux@...ck-us.net
Subject: Re: [PATCH net] net: dsa: Do not override PHY interface if already
 configured

On 12/08/15 14:30, David Miller wrote:
> From: Florian Fainelli <f.fainelli@...il.com>
> Date: Sat,  8 Aug 2015 12:58:57 -0700
> 
>> In case we need to divert reads/writes using the slave MII bus, we may have
>> already fetched a valid PHY interface property from Device Tree, and that
>> mode is used by the PHY driver to make configuration decisions.
>>
>> If we could not fetch the "phy-mode" property, we will assign p->phy_interface
>> to PHY_INTERFACE_MODE_NA, such that we can actually check for that condition as
>> to whether or not we should override the interface value.
>>
>> Fixes: 19334920eaf7 ("net: dsa: Set valid phy interface type")
>> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
>> ---
>> Hi Guenter,
>>
>> Could you verify this does not break what you were trying to fix with your change?
>> I am fairly confident this will not because for "PHYs" built-into the switch port
>> we will not be able to fetch a "phy-mode" property from DT, so we will use
>> PHY_INTERFACE_MODE_NA, but here, we will re-assign them to PHY_INTERFACE_MODE_GMII
>> as before.
> 
> I was trying to wait for Guenter's testing before applying this, but it's been some
> time already and it makes no sense to wait any longer.

I should be able to verify this myself in the future since I just setup
a Marvell/DSA switch device here for testing.

> 
> Applied to 'net', thanks Florian.

Could you also schedule this for -stable, at least 4.1 is affected by
this change, thank you!
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html