netdev - Re: [PATCH] net: Use SK_MEM_QUANTUM as minimum for tcp/udp rmem/wmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150813210704.GA3055575@mail.thefacebook.com>
Date:	Thu, 13 Aug 2015 14:07:04 -0700
From:	Calvin Owens <calvinowens@...com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	Sorin Dumitru <sorin@...urnze.ro>,
	Sorin Dumitru <sdumitru@...acom.com>,
	David Miller <davem@...emloft.net>, <kuznet@....inr.ac.ru>,
	<jmorris@...ei.org>, <yoshfuji@...ux-ipv6.org>, <kaber@...sh.net>,
	netdev <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<kernel-team@...com>
Subject: Re: [PATCH] net: Use SK_MEM_QUANTUM as minimum for tcp/udp rmem/wmem

On Wednesday 08/12 at 10:46 -0700, Eric Dumazet wrote:
> On Wed, 2015-08-12 at 20:00 +0300, Sorin Dumitru wrote:
> 
> > Would clamping the values to a min value, like setsockopt(SO_SNDBUF)
> > does, be an option?
> > I still find it odd that SO_SNDBUF limits you, while the /proc
> > interface doesn't. If you think it's
> > too much, I'm ok with reverting it since it affects scripts.
> > 
> > On those arches where PAGE_SIZE == 64K(or > 16K) it looks like we have
> > tcp_wmem[1]
> > smaller than tcp_wmem[0]. Shouldn't we do something about this?
> 
> As long as we do not crash if/when root user changes /proc/sys/net
> settings, we are good.

Using "1 1 1" for tcp_{r,w}mem seems not to explode, so this sounds good
to me. I'll send a new patch reverting the original.

Thanks,
Calvin

> I would not care if performance is bad if root does something really
> stupid. root user is supposed to not mess things just for fun.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html