netdev - Re: [PATCH net-next 5/6] geneve: Consolidate Geneve functionality in single module.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEP_g=-BUb8Uyh3hYGt3b=J62fW9Kvm+yf3ySZwVOmMurKNf1g@mail.gmail.com>
Date:	Thu, 13 Aug 2015 14:24:05 -0700
From:	Jesse Gross <jesse@...ira.com>
To:	Pravin Shelar <pshelar@...ira.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 5/6] geneve: Consolidate Geneve functionality in
 single module.

On Wed, Aug 12, 2015 at 4:33 PM, Pravin Shelar <pshelar@...ira.com> wrote:
> On Wed, Aug 12, 2015 at 2:55 PM, Jesse Gross <jesse@...ira.com> wrote:
>> The farther I go in the series, the more that I hope that we can avoid
>> the use of collect_md_tun. It really seems to add a lot of special
>> cases.
>
> Use of collect_md_tun allows us to avoid hash table lookup. thats why
> I did it. Anyways we need a flag or pointer in geneve-sock structure
> to locate tunnel metadata. I dont see how is it simple if
> collect_md_tun is replaced with a flag.

It seems to me that this requires more bookkeeping to keep consistent
(a little in the code but mostly mentally) because collect_md_tun is a
separate concept that doesn't necessarily follow the same rules as
other tunnels. With VXLAN, I feel like I can mostly ignore this tunnel
since it isn't special in most ways with the exception of places where
it actually needs to do something different like allocate metadata.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html